feat(api-client): P005 - Add name and description fields to CustomGeoCollection#1300
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(api-client): P005 - Add name and description fields to CustomGeoCollection#1300yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
Add name and description fields to CustomGeoCollection and DeclarativeCustomGeoCollection models following changes in gdc-nas metadata-api. The fields support: - Descriptive name for custom geo collections (max 255 chars) - Description text for custom geo collections (max 10000 chars) Changes: - Regenerated API client from updated OpenAPI spec - Added name and description fields to DeclarativeCustomGeoCollection model - Added attributes with name and description to JSON:API CustomGeoCollection models - Updated all related JSON:API input, output, and patch models Related to problem P005 from gdc-nas sync. Based on gdc-nas commit: 35a2b71798b4b8e2d1ca23f5b2dc99cd3b5fa63e Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
|
Testing of SDK - Please close I apologize for spam, for future i will test it on my fork but i forgot to switch it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronize Python SDK with gdc-nas changes for problem P005: Add name and description fields to CustomGeoCollection models.
Changes in gdc-nas
nameanddescriptionfields to CustomGeoCollection and DeclarativeCustomGeoCollection modelsChanges in Python SDK
name(max 255 chars) anddescription(max 10000 chars) fields to DeclarativeCustomGeoCollection modelnameanddescriptionto JSON:API CustomGeoCollection models (In, Out, Patch)Details
Testing
The changes are auto-generated from the OpenAPI specification. Users can now:
nameanddescriptionfields on CustomGeoCollection entities🤖 Generated with Claude Code